Cause: transduce passes (xf f) into .reduce of Eduction, which calls transduce, causing completing xf to be called more than once.
Proposed: Eduction reduce should use (completing f) instead of f to isolate completion of inner xf from outer xf.
Patch: CLJ-1606-5.patch
Screened by: Alex Miller
1.7.0-alpha4
Andy, not sure how to do that, but in any case I just added -5 clarifying language in the comment
Ghadi, that was super confusing. Did you just add a new -5 patch? The -4 patch has already been screened, and you have not removed the duplicate -2 patch so I don't get what the -5 is. Can we just delete the -5 and older -2 patches?
Sorry for adding to the confusion. Ghadi, instructions for deleting patches are in the "Removing patches" section on this wiki page: http://dev.clojure.org/display/community/Developing+Patches
Sorry. Fine by me, though permissions prevent me from deleting one of the patches.
As I read through the screened patch I just tried to clarify the wording. This:
;; NB (completing f) isolates completion of inner xfns from outer xfns
became:
;; NB (completing f) isolates completion of inner rf from outer rf
Feel free to nix that -5 patch if that's worthless
Gotcha. I will take care of the further changes later tonight.
In the future, please don't modify screened patches without letting me know.