Uploaded image for project: 'Clojure'
  1. CLJ-1537

Audit IReduce usages for proper Reduced handling

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Completed
    • Affects versions: Release 1.7
    • Fix versions: Release 1.7
    • Labels:
      None
    • Patch:
      Code

      Description

      Rich asked that we make sure that all usages of IReduce properly handle Reduced semantics.

      Approach: I did a "Find Usages" in InteliJ and updated usages of IReduce as needed.

      Example: Before the patch:

      user=> (transduce (take 1) conj (seq (subvec [1 2 3 4 5] 1)))
      #<Reduced@13df2a8c: #<Reduced@1ebea008: #<Reduced@72d6b3ba: #<Reduced@1787f2a0: [2]>>>>
      
      user=> (transduce (take 1) conj '(1 2 3 4))
      #<Reduced@51bd8b5c: #<Reduced@7b50df34: #<Reduced@1b410b60: #<Reduced@2462cb01: [1]>>>>
      

      Patch: clj-1537-v3.diff
      Screened by: Alex Miller

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              halgari Timothy Baldridge
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: