Add transient keyword to cached toString() value in _str
Description
_str field in Keyword and Symbol classes lazily caches result of toString(). Because this field is not transient, serializing (using Java serialization) any keyword or symbol before and after calling toString() for the first time yields different results:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
(import (java.io ByteArrayOutputStream ObjectOutputStream
ByteArrayInputStream ObjectInputStream))
(defn- serialize [obj]
(with-open [bos (ByteArrayOutputStream.)
stream (ObjectOutputStream. bos)]
(.writeObject stream obj)
(-> bos .toByteArray seq)))
;; keyword example
(def k1 (serialize :k))
(println :k)
(def k2 (serialize :k))
(= k1 k2) ;;=> false
;; symbol example
(def sym 'a)
(def s1 (serialize sym))
(println sym)
(def s2 (serialize sym))
(= s1 s2) ;;=> falseThis issue came up when I was trying to use keywords as key in [Hazelcast](https://github.com/hazelcast/hazelcast) map. Hazelcast uses serialized keys in various scenarios, thus if I first put something to map under key :k and then print :k, I can no longer find such key.
Approach: Add transient keyword to _str field in Keyword and Symbol classes
Patch: CLJ-1408-3.patch
Screened by: Brenton Ashworth
Environment
None
Status
Assignee
Unassigned
Reporter
Tomasz Nurkiewicz
Labels
Approval
Ok
Patch
Code and Test
Fix versions
Affects versions
Release 1.6
Priority
MinorConfigure