Hints don't work with #() form of function

Description

Example showing how a local fn can be hinted but an anonymous function cannot:

Cause: Functions have metadata, but Compiler does not look in them for type hints. Var expressions and local bindings use :tag metadata to override return of getJavaClass(). Compiler parses #() into a FnExpr, which always return AFunction as its class.

Proposed: Change FnExpr.getJavaClass() to return tag as type if it is available.

Patch: clj-1378-v2.diff

Screened by: Alex Miller

Environment

None

Activity

Show:
Jozef Wagner
March 12, 2014, 9:03 PM

Functions do have metadata, but Compiler does not look in them for type hints.

When compiler is determining which native method to use, it matches method signature with classes of given args. There is a getJavaClass() method in Compiler.java which returns a class for given expression. Vars expressions and local bindings use :tag metadata to override this class, but most other expressions don't. Compiler parses #() into a FnExpr, which always return AFunction as its class.

Most of time this approach is OK, as AFunction implements Runnable and Callable so there is no need for type hint. However, in this particular case, there are overrides for both Runnable and Callable, and as AFunction can be either of them, the expression is ambiguous.

Jozef Wagner
March 12, 2014, 9:17 PM

Patch added, following expression will now run without error

Alex Miller
March 13, 2014, 2:34 AM

Could you add a test to the patch?

Jozef Wagner
March 13, 2014, 7:53 AM

Attached patch clj-1378-v2.diff which contains both fix and test.

Completed

Assignee

Unassigned

Reporter

import

Labels

Approval

Ok

Patch

Code and Test

Fix versions

Priority

Major