set! of a deftype field using field-access syntax causes ClassCastException
Description
set! can be used to set a public field on an instance with (set! (.field inst) val). This does not work inside a protocol function defined on a deftype with a mutable field for an instance of that type itself.
Cause: The type assigned in the bytecode at this point is the compile_stub type, not the expected class type.
Approach: Use getType(targetClass) instead of Type.getType(targetClass)
Patch: 0001-CLJ-1226-fix-set-of-instance-field-expression-that-r-v2.patch
Screened by: Fogus
Environment
Activity
This patch offers a better workaround for CLJ-1075, making it possible to write
(deftype foo [^:unsynchronized-mutable x] MutableX (set-x [this v] (try (set! (.x this) v)) v))
Updated patch to apply to current master
Straight-forward fix and test.
Screeners - please make sure the patch has an Approach section that explains how and why the patch will fix the problem. Symptom is X and now after patch behavior is Y is not good enough.
Assignee
Reporter
Approval
Patch
Fix versions
Affects versions
Priority
