Unnecessary get during SoftCache lookup

Description

Currently during a lookup (without default value) on the SoftCache we'll use the result of (.get r) for the ::nil-check and then get it again as we're about to return it. It's possible this could result in inconsistency but it's also an unnecessary call.

I've provided a patch which reuses the result of the get for the check and return value.

Environment

None

Activity

Show:
Sean Corfield
January 6, 2019, 10:33 PM

Will be in 0.7.2

Sean Corfield
December 21, 2018, 2:02 AM

Alex confirmed receipt of your CLA. Thank you! I'll probably take a look at these issues over the holiday break some time.

import
December 20, 2018, 8:14 AM

My apologies. It turns out that running through the process twice wasn't enough for me to spot the 'Click here to sign' button hidden under the cookie warning (which I now find I ignore across all sites).

I have had the email confirmation and it all looks like it has gone through.

Sean Corfield
December 19, 2018, 9:05 PM

They have not received your signed agreement. There's an email verification step – did you get the email? Did you click on the verification link? Without that step, the process isn't complete.

Sean Corfield
December 19, 2018, 7:26 PM

I've pinged Alex again. I gather the site publishing process just broke due to some infrastructure changes so things are more manual than usual. Thanks for the reminder!

Completed

Assignee

Sean Corfield

Reporter

import

Labels

Approval

None

Patch

Code

Priority

Minor